Re: 6/7 [Fortran, Patch, Coarray, PR107635] Add transfer_between_remotes

[Andre Vehreschild]

Hi Rainer,

thanks for testing and also for giving a solution. I was sure, I would break
something. Fixed as obvious as gcc-15-7662-g08bdc2ac98a after regtesting ok on
x86_64-pc-linux-gnu / Fedora 41 (which gets more unstable with every update I
receive IMO). I opted for the __builtin_alloca version. That seemed to be the
most portable one.

Thanks again for the report and keep testing please,
        Andre

On Thu, 20 Feb 2025 19:26:41 +0100
Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:

> Hi Andre,
> 
> this patch broke Solaris bootstrap:
> 
> /vol/gcc/src/hg/master/local/libgfortran/caf/single.c: In function
> ‘_gfortran_caf_transfer_between_remotes’:
> /vol/gcc/src/hg/master/local/libgfortran/caf/single.c:675:23: error: implicit
> declaration of function ‘alloca’ [-Wimplicit-function-declaration] 675 |
>  transfer_desc = alloca (desc_size); |                       ^~~~~~
> /vol/gcc/src/hg/master/local/libgfortran/caf/single.c:675:23: warning:
> incompatible implicit declaration of built-in function ‘alloca’
> [-Wbuiltin-declaration-mismatch]
> /vol/gcc/src/hg/master/local/libgfortran/caf/single.c:680:20: warning:
> incompatible implicit declaration of built-in function ‘alloca’
> [-Wbuiltin-declaration-mismatch] 680 |     transfer_ptr = alloca
> (*opt_dst_charlen * src_size); |                    ^~~~~~ make[3]: ***
> [Makefile:4675: caf/single.lo] Error 1
> 
> Solaris needs to include <alloca.h> to get an alloca declaration.  While
> this could be handled with AC_FUNC_ALLOCA (like libcpp does) or checking
> for alloca.h and including it if found (like libssp does), I guess
> there's a simpler way: several runtime libs use __builtin_alloca
> unconditionally (libgcc, libquadmath, libstdc++-v3).
> 
>       Rainer
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 

From 76b2b1ee14024bba0a618ee98505550cd7c41a1d Mon Sep 17 00:00:00 2001
From: Andre Vehreschild <ve...@gcc.gnu.org>
Date: Fri, 21 Feb 2025 08:18:40 +0100
Subject: [PATCH] Fortran: Fix build on solaris [PR107635]

libgfortran/ChangeLog:

	PR fortran/107635
	* caf/single.c: Replace alloca with __builtin_alloca.
---
 libgfortran/caf/single.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libgfortran/caf/single.c b/libgfortran/caf/single.c
index d4e081be4dd..9c1c0c1bc8c 100644
--- a/libgfortran/caf/single.c
+++ b/libgfortran/caf/single.c
@@ -672,12 +672,12 @@ _gfortran_caf_transfer_between_remotes (
   if (!scalar_transfer)
     {
       const size_t desc_size = sizeof (*transfer_desc);
-      transfer_desc = alloca (desc_size);
+      transfer_desc = __builtin_alloca (desc_size);
       memset (transfer_desc, 0, desc_size);
       transfer_ptr = transfer_desc;
     }
   else if (opt_dst_charlen)
-    transfer_ptr = alloca (*opt_dst_charlen * src_size);
+    transfer_ptr = __builtin_alloca (*opt_dst_charlen * src_size);
   else
     {
       buffer = NULL;
--
2.48.1