On 2/9/25 12:54 AM, Thomas Koenig wrote:
Am 08.02.25 um 22:46 schrieb Harald Anlauf:
looks good, just two minor comments:
+ actual_name = act_sym->name ? act_sym->name : act_sym->name;
Why not just
+ actual_name = act_sym->name;
?
That was a leftover from a previous commit.
+ gfc_error ("Type mismatch passing global function %qs "
+ "declared at %L at %L (%s/%s)", actual_name,
+ &gsym->where, &actual->where,
+ gfc_typename (&global_asym->ts),
+ gfc_dummy_typename (&formal->ts));
These result in lines exceeding column 80.
Fixed.
I am also not a native speaker, but "at %L at %L" sounds strange to me.
Could you find a minor rewording?
I tried, but I could not find anything better...
So, if anybody can think of a more clever wording, the patch for
this is pre-approved :-)
Committed as r15-7449, thanks for the review!
Best regards
Thomas
Try:
"Type mismatch at %L when passing global function %qs "
"declared at %L (%s/%s)"
Jerry
