Found using UBSAN - and thanks to Martin for running it with UBSAN
and reporting it!
append_args and adjust_args can be easily confused being spelled
rather similarly and being used in the same code. Still, it makes
sense to use the right list...
(It seems as if the pointer dereferencing actually does not happen,
i.e. in that sense the code is "fine" as it does not crash. Still,
having NULL + some offset is not the best pointee.)
Committed asr15-7366-g3a5882707df50e Tobias
commit 3a5882707df50ed29905b3c47cbaa0868ea248c9
Author: Tobias Burnus <tbur...@baylibre.com>
Date: Wed Feb 5 08:44:41 2025 +0100
fortran/trans-openmp.cc: Use the correct member in gfc_omp_namelist [PR118745]
gcc/fortran/ChangeLog:
PR fortran/118745
* trans-openmp.cc (gfc_trans_omp_declare_variant): Use
append_args_list in the condition for the append_arg location.
---
gcc/fortran/trans-openmp.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/fortran/trans-openmp.cc b/gcc/fortran/trans-openmp.cc
index a593f5a8e5e..e29ef85ae39 100644
--- a/gcc/fortran/trans-openmp.cc
+++ b/gcc/fortran/trans-openmp.cc
@@ -8839,7 +8839,7 @@ gfc_trans_omp_declare_variant (gfc_namespace *ns)
last_arg->next = extra_arg;
else if (extra_arg)
variant_proc_sym->formal = extra_arg;
- locus *loc = (odv->adjust_args_list
+ locus *loc = (odv->append_args_list
? &odv->append_args_list->where : &odv->where);
int nextra_arg = 0;
for (; extra_arg; extra_arg = extra_arg->next)
