Hi Andre, I don't know the answer to your question but was following practice that is followed elsewhere in gfortran with DECL_EXPRs by generating nameless declarations in local scope.
Thanks for the review. Paul On Tue, 10 Dec 2024 at 10:20, Andre Vehreschild <ve...@gmx.de> wrote: > Hi Paul, > > the patch looks ok to me, but one questions remains: > > You are doing this for all character arrays. Would it not be sufficient to > create the DECL only for deferred chararrays? > > Ok for mainline and with a grace period for backporting. > > Thanks for the patch, > Andre > > On Tue, 10 Dec 2024 08:46:10 +0000 > Paul Richard Thomas <paul.richard.tho...@gmail.com> wrote: > > > Hi All, > > > > This was a rather vexatious bug to track down and squash. I was led > astray > > by the appearance of the bug in the tests for the implementation of > > intrinsic transformational functions with class arguments. It turns out > to > > be an incipient bug in the handling of character(*) array associate names > > that is fixed by provision of an appropriate DECL_EXPR. > > > > Note that I have not attempted to fix the apparent regression > > in tree-ssanames.cc, which occurred sometime between gcc-12.2.1 and > > gcc-12.4.1. Once this patch is pushed, I will convert the PR accordingly. > > > > Furthermore, PR101760(fortran) and PRs 96114/117145(C). I'll turn to the > > former, once the dust has settled on the regressions that I have caused > in > > recent weeks. > > > > The patch regression tests fine. OK for mainline? > > > > Paul > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de >
