On 11 October 2024 16:42:44 CEST, David Malcolm <dmalc...@redhat.com> wrote: >On Fri, 2024-10-11 at 15:34 +0100, Paul Richard Thomas wrote: >> Hi Tobias, >> >> Good catch! It looks 'obvious' to me too :-)
yeah, thanks for the explicit cleanup >> > * I want to move support range-based locations, which is also a >> > good >> > opportunity to fix some misplaced '1' (e.g. which point at white >> > space >> > instead of the actual declaration or ...). yep. We have this nasty bug that locus and comments (maybe with or without continuation, don't remember the format or all) do havoc to locus (see BZ) This is solved when we use locus that support ranges (and somebody going throught the FE) & >> > >> > * David wants to improve json/sarif output, including stderr + >> > sarif/json >> > output at the same time, but that has issues with >> > delayed/suppressed/buffered >> > diagnostic in gfortran (because of the try & error parsing* in >> > Fortran) >> > → https://gcc.gnu.org/PR116613 for the former and >> > https://gcc.gnu.org/105916 >> > for the buffering issue. > >Thanks for the patch; I was planning to take a look at the SARIF >buffering issue later today/Monday from the gcc/diagnostic.cc/h side >(perhaps introducing an idea of "pending diagnostics" there), so any >simplifications on the fortran side are most welcome! My knowledge of >Fortran is almost zero, sorry. > >Dave >
