> Date: Wed, 25 Sep 2024 13:51:07 +0200 > From: Andre Vehreschild <ve...@gmx.de>
> Hi Hans-Peter, > > preface: I am not a testsuite nor an m4 expert. Neither am I. Luckily, this has nothing to do with m4, and not really that much to do with tcl or dejagnu either, being just basic code, no language-specific tricks. > So I may be wrong in arguing that your changes look reasonable. I like the > "automatic" clean-up process very much. So by me, ok for mainline. But you may > want to wait for one other ok from some one who has more experience in > the gfortran testsuite (yes, still wondering who that might be :-( ). > > Thanks for the patch, > Andre And thank you for the review! Now, the point of my reply wasn't neither a comical point nor thankfulness (I am, but it counts toward the mailing list traffic), but mostly to FAOD point out that this part: > > I hope the inclusion of gfortran-dg.exp in > > fortran-torture.exp is not controversial, but there's no > > fortran-specific testsuite file common to dg and > > classic-torture and also this placement is still in the > > "Utility routines" section of gfortran-dg.exp. (BTW, the C > > torture-tests changed to the dg framework some time ago - no > > more .x-files there and dg-directives actually work - there > > are some in gfortran.fortran-torture that are apparently > > ignored!) ...slipped by from v1 by copy-pasto accident. Still, it was above the "scissors line" in the patch message, and would not have made it to the commit log. brgds, H-P
