> >>> I noticed by chance that we have quite a lot of improperly specified do-do > >>> directives in the testsuite. > >>> > >>> % grep "dg-do run" gcc/testsuite/gfortran.dg/ -rl|wc -l > >>> 83 > >>> > > > > I think this is on purpose. > > The idea to use a "feature" in dejagnu to only iterate once and not > > over all possible options. So execution time can be lowered a bit. > > > > But I don't know if this hack still works, it definitely did work some > > years ago. > > > > Cheers, > > Manfred
Is this "feature" documented somewhere? I don't see it on https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gccint/Directives.html Given that the dg-directives are important and possibly fragile, and since we had issues in the past, can we check that a test that was added works the way intended? > >>> Note that with two blanks instead of just one a testcase does not get > >>> executed. > >>> > >>> Does anybody want to earn the honors to change the directives and > >>> check for "fallout" in the testsuite? > >>> > >>> Cheers, > >>> Harald > >>> > >> > >> One failure after fixing all the spaces ( sed is our friend ). > >> > >> FAIL: gfortran.dg/inline_matmul_1.f90 -O0 scan-tree-dump-times > >> optimized "_gfortran_matmul" 0 This does actually point to an issue with the testcase: it only works properly with optimization enabled. Manual inspection of this test and the expected dump suggests that e.g. -O1 could have been added to the dg-options directive. Shouldn't we fix at least the dg-options of that testcase? Cheers, Harald > >> Jerry - > > > > Yes it still works, I noticed the tests will do two passes each rather > than 12 per file. > > I will hold off on doing anything with these. > > Regards, > > Jerry - >
