Le 23/09/2022 à 09:54, Mikael Morin a écrit :
Le 22/09/2022 à 22:42, Harald Anlauf via Fortran a écrit :
I was wondering if you could add a test for the change in patch 7
addressing the clobber generation for an associate-name, e.g. by
adding to testcase intent_optimize_7.f90 near the end:

   associate (av => ct)
     av = 111222333
     call foo(av)
   end associate
   if (ct /= 42) stop 3

plus the adjustments in the patterns.

Indeed, I didn't add a test because there was one already, but the existing test hasn't the check for clobber generation and store removal. I prefer to create a new test though, so that the patch and the test come together, and the test for patch 8 is not encumbered with unrelated stuff.

By the way, the same could be said about patch 6.
I will create a test for that one as well.

Patches pushed:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=77bbf69d2981dafc2ef3e59bfbefb645d88bab9d

Changes from v2:
 - patches 6 and 7: A test for each has been added.
 - patches 8 and 9: The tests have been renumbered.
 - patches 6 and 7: The PR number used in the subject line has been
     changed, from the different regression PRs to the one optimization PR.
- patches 5 and 8: The commit message has been modified: the commit the patch
     partly reverts is mentioned, and the associated PR number as well.
 - patch 7: The regression PR number this refers to has been changed.

Reply via email to