> > Since this is old code without a lot of tests behind in, in this case the > best practice would be to touch as little code as possible.
I agree... I did ran a full mustella pass though, to be sure, before committing. I assume not even that is enough then, and that some parts of code may be uncovered, right? 2012/12/19 Carol Frampton <cfram...@adobe.com> > > > On 12/19/12 5 :40PM, "Justin Mclean" <jus...@classsoftware.com> wrote: > > >Hi, > > > >> I don't think that's the right change. I'm guessing the intent is to > >>change > >> a local variable, not the instance's height property? > > > > > >Nice catch. Calling a variable the same as a local property is probably a > >bad idea. Best fix here I think would be to rename height to something > >else? > > > Since this is old code without a lot of tests behind in, in this case the > best practice would be to touch as little code as possible. > > Carol > >
