On 12/30/2019 8:07 PM, Derek Buitenhuis wrote: > On 30/12/2019 19:20, James Almer wrote: >> + if (ctx->api->param_parse(ctx->params, key, buf) == >> X265_PARAM_BAD_VALUE) { >> + av_log(avctx, AV_LOG_ERROR, "Invalid value %d for param \"%s\".\n", >> value, key); >> + return AVERROR(EINVAL); >> + } > > Does returning error make sense here (soft fail)?
We fail for all failed param_parse calls except for the ones from x265_opts. I'm fine just printing a warning and letting the encoding process continue if you prefer. I could also make it abort only if explode err_detect flag is set. > > Code LGTM. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".