Hi Alexander,
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, 8 de August de 2019 1:43, Alexander Strasser <eclip...@gmx.net> wrote: > On 2019-08-07 15:51 +0000, Andreas Håkon wrote: > > > Hi, > > This new version changes the name of the filter, and implements all > > suggestions. > > Thanks for renaming; "timeshift" sounds better to me, compared to > the previous "timer". > > Other suggestions which I came up with: > > - adjust_timestamps > - edit_timestamps > > Instead of the _timestamps suffix _ts or _ptsdts could be used. I like the name "edit_ts", it's short and clear. Opinions? > Maybe others have better suggestions. For me the current name > timeshift is acceptable. If you decide to rename it yet again, > I would recommend to not send new versions of the patch with > only name change for now. It's better to wait for potential > review comments. OK. > To make it clear I did only read your patch and didn't review > it at all. I wanted to comment on the name in time, because it's > always significantly more effort to deal with user visible naming > once the code is merged. I hope someone will review it soon. Regards. A.H. --- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
