On 2019-08-07 15:51 +0000, Andreas Håkon wrote: > Hi, > > This new version changes the name of the filter, and implements all > suggestions.
Sorry, I couldn't reply earlier. Thanks for renaming; "timeshift" sounds better to me, compared to the previous "timer". Other suggestions which I came up with: * adjust_timestamps * edit_timestamps Instead of the _timestamps suffix _ts or _ptsdts could be used. Maybe others have better suggestions. For me the current name timeshift is acceptable. If you decide to rename it yet again, I would recommend to not send new versions of the patch with only name change for now. It's better to wait for potential review comments. To make it clear I did only read your patch and *didn't review* it at all. I wanted to comment on the name in time, because it's always significantly more effort to deal with user visible naming once the code is merged. Alexander > Supersedes: > https://patchwork.ffmpeg.org/patch/14195/ > https://patchwork.ffmpeg.org/patch/13743/ > https://patchwork.ffmpeg.org/patch/13699/ > > Regards. > A.H. > > --- > From 9e036e0a1dc20fd5c41686a48a5a0c2142f91de4 Mon Sep 17 00:00:00 2001 > From: Andreas Hakon <andreas.ha...@protonmail.com> > Date: Wed, 7 Aug 2019 17:45:25 +0200 > Subject: [PATCH] libavcodec: add timeshift bitstream filter [v3] > > This implements the new timeshift bitstream filter. > > Signed-off-by: Andreas Hakon <andreas.ha...@protonmail.com> > --- > doc/bitstream_filters.texi | 11 +++++ > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/timeshift_bsf.c | 87 > ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 100 insertions(+) > create mode 100644 libavcodec/timeshift_bsf.c > [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
