On 28.07.2019, at 10:40, Nick Renieris <velocit...@gmail.com> wrote: > Actually, I checked a more accurate version of my loop, and GCC > optimizes away the LUT check anyway: > https://godbolt.org/z/G1e1R4 > As you can see it's smart enough to create 2 versions of my functions > (started at L3 with a lookup and L7 without it) and it does the check > outside. > > There's no guarantee this is happening with the actual version of > course (it could be slower, or even faster if it also optimizes it > through dng_blit). > I could check the actual disasm in FFmpeg, but I don't think it's > worth it at this point (my mentor agrees).
Sorry, I did not know you already had discussions with an FFmpeg developer about the design. I tend to review in a way that I just comment on anything I feel is not optimal. I understand that much of it might not be reasonable to do differently in the end, but feel that it is often enough to make it worth discussing things. But I realize it can come across the wrong way, so sorry if I gave you a bad review experience, and thanks for considering my comments. Best regards, Reimar _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
