> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Friday, March 01, 2019 6:13 AM > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/5] vaapi_encode: Add ROI support > > On Wed, Feb 27, 2019 at 10:00:22PM +0000, Mark Thompson wrote: > > --- > > libavcodec/vaapi_encode.c | 129 > ++++++++++++++++++++++++++++++++ > > libavcodec/vaapi_encode.h | 9 +++ > > libavcodec/vaapi_encode_h264.c | 2 + > > libavcodec/vaapi_encode_h265.c | 2 + > > libavcodec/vaapi_encode_mpeg2.c | 2 + > > libavcodec/vaapi_encode_vp8.c | 2 + > > libavcodec/vaapi_encode_vp9.c | 2 + > > 7 files changed, 148 insertions(+) > > In file included from libavcodec/vaapi_encode.c:27:0: > libavcodec/vaapi_encode.h:73:5: error: unknown type name ‘VAEncROI’ > VAEncROI *roi; > ^ > make: *** [libavcodec/vaapi_encode.o] Error 1
looks that we'd add a libva version check, this struct is defined at libva repo. ./va/va.h:2259:} VAEncROI; I yesterday just did 'git pull' for the following repos: https://github.com/intel/libva https://github.com/intel/gmmlib.git https://github.com/intel/media-driver.git > make: *** Waiting for unfinished jobs.... > In file included from libavcodec/vaapi_encode_mpeg2.c:28:0: > libavcodec/vaapi_encode.h:73:5: error: unknown type name ‘VAEncROI’ > VAEncROI *roi; > ^ > make: *** [libavcodec/vaapi_encode_mpeg2.o] Error 1 > POD doc/ffprobe.pod > In file included from libavcodec/vaapi_encode_h264.c:36:0: > libavcodec/vaapi_encode.h:73:5: error: unknown type name ‘VAEncROI’ > VAEncROI *roi; > ^ > make: *** [libavcodec/vaapi_encode_h264.o] Error 1 > > > > [...] > -- > Michael GnuPG fingerprint: > 9FF2128B147EF6730BADF133611EC787040B0FAB > > Dictatorship: All citizens are under surveillance, all their steps and > actions recorded, for the politicians to enforce control. > Democracy: All politicians are under surveillance, all their steps and > actions recorded, for the citizens to enforce control. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
