On 12/5/18, 6:10 PM, "Tobias Rapp" <t.r...@noa-archive.com> wrote: > >On 05.12.2018 07:18, Karthick J wrote: >> [...] >> + if (mov->flags & FF_MOV_FLAG_GLOBAL_SIDX && s->flags & >> FF_MOV_FLAG_SKIP_SIDX) { >> + av_log(s, AV_LOG_WARNING, "Global SIDX enabled; Ignoring skip_sidx >> option\n"); >> + s->flags &= ~FF_MOV_FLAG_SKIP_SIDX; >> + } >> + > >I guess this should use mov->flags instead of s->flags? Oops. Sorry about it. Thanks for pointing it out. Have sent PATCH v3 with this change. http://ffmpeg.org/pipermail/ffmpeg-devel/2018-December/237232.html
> >> [...] > >Otherwise changes look fine, but I am not the maintainer of this file. > >Regards, >Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel