On Wed, Nov 29, 2017 at 20:16:16 +0100, Paul B Mahol wrote:
> +@item mode
> +Set fill mode.
> +
> +It accepts the following values:
> +@table @samp
> +@item smear
> +fill pixels using outermost pixels
> +
> +@item mirror
> +fill pixels using mirroring
> +
> +@item fixed
> +fill pixels with constant value
> +@end table
"Default value is @code{smear}."
> +Set color for pixels in fixed mode. Defauls is @var{black}.
Typo: ^ Default
> + s->yuv_color[Y] = RGB_TO_Y_CCIR(s->rgba_color[R], s->rgba_color[G],
> s->rgba_color[B]);
> + s->yuv_color[U] = RGB_TO_U_CCIR(s->rgba_color[R], s->rgba_color[G],
> s->rgba_color[B], 0);
> + s->yuv_color[V] = RGB_TO_V_CCIR(s->rgba_color[R], s->rgba_color[G],
> s->rgba_color[B], 0);
> + s->yuv_color[A] = s->rgba_color[A];
This RGB to YUV calculation could go into the else block below, since
it's only required/used there, right?:
> + if (desc->flags & AV_PIX_FMT_FLAG_RGB) {
> + memcpy(s->fill, s->rgba_color, sizeof(s->rgba_color));
> + } else {
> + memcpy(s->fill, s->yuv_color, sizeof(s->yuv_color));
> + }
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
