On 11/29/2017 3:58 PM, Hendrik Leppkes wrote:
The same applies here as with twolame, we don't really want to duplicate all sorts of checks, so if pkg-config has been available for a sufficiently long time, then just use it always.
Ok. TwoLAME is pretty clear-cut, but OpenAL raises more questions. The configure check says 'OpenAL 1.1 or compatible'. If we're assuming openal-soft rather than the really old Creative SDK, then the git history of openal.pc.in its current location dates back to version 1.11.753, in 2009 (the .pc.in file first appeared in 2008, which appears to be with version 1.5.304). Practically, I think it's safe to assume users are going to fetch a reasonably current version of openal-soft, but for precision's sake should that mean we force a version check so that version 1.11.753 (or 1.12 for convenience?) or higher is required? And at that point the description for --enable-openal would probably need to change so that it explicitly states using openal-soft. I thought I remembered OpenAL coming up in a discussion on ffmpeg-devel on pkg-config sometime a few months ago (or maybe it was on Trac?), and there was something mentioned about OS X or file paths not always leading to the correct .pc file, and that using pkg-config couldn't always find it. I can't seem to find that now, though. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
