On 08/03/2017 01:53 AM, Mark Thompson wrote:
+        return ret;
+    }
+
+    av_log(log_ctx, AV_LOG_INFO, "Using device %s\n", tmpbuf);
+    ret = probe_and_set(s, log_ctx, 1);
+    s->devname = devname_save;
This probing structure feels very fragile and possibly harmful (opening random 
devices and poking them).  It might be better to just force the user to supply 
the right device path?

+
I cleaned it up on v4 but I dont think it can be done much differently: the user needs to query the capabilities of every /dev/videoX node..

btw the same probing is already done in  libavdevice/v4l2.c
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to