2017-04-14 18:18 GMT+02:00 Rostislav Pehlivanov <atomnu...@gmail.com>: > On 14 April 2017 at 13:34, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > >> 2017-04-14 14:30 GMT+02:00 Carl Eugen Hoyos <ceffm...@gmail.com>: >> > 2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov <atomnu...@gmail.com>: >> >> >> Point is, I have used only code from libavcodec/opus_pvq.c from >> >> the FFmpeg project. I don't have to do anything as all credit has >> >> been given where due. >> > >> > I don't understand: >> > The file opus_pvq.c contains copyright notices from Andrew >> > D'Addesio and Mozilla. If you have used code from opus_pvq.c, >> > shouldn't you add these copyright notices to the opus encoder? >> >> Or did you mean that you only used code that was already >> present in libavcodec/opus_pvq.c without copying anything >> to the new files you wrote (what "using" implied to me)?
> Yes, that is what I mean. > Initially, all code from opus_pvq.c was in opus_celt.c. To tidy the decoder > and reuse the code there for the encoder, I created opus_pvq.c, copying the > header and keeping all the copyright as is. I then implemented encoding > functionality (modifying existing code and writing new code) and added my > copyright there as well. That's all. Thank you for the clarification, patch sent. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
