On 12/23/16, Nicolas George <geo...@nsup.org> wrote: > Le duodi 2 nivôse, an CCXXV, James Almer a écrit : >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> libavcodec/pixlet.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/pixlet.c b/libavcodec/pixlet.c >> index c5d37bb..c1bd321 100644 >> --- a/libavcodec/pixlet.c >> +++ b/libavcodec/pixlet.c >> @@ -457,7 +457,7 @@ static void postprocess_luma(AVFrame *frame, int w, >> int h, int depth) >> uint16_t *dsty = (uint16_t *)frame->data[0]; >> int16_t *srcy = (int16_t *)frame->data[0]; >> ptrdiff_t stridey = frame->linesize[0] / 2; >> - const float factor = 1. / ((1 << depth) - 1); >> + const float factor = 1.0f / ((1 << depth) - 1); > > Any reason, here and everywhere, to do it that way and not the other way > around, i.e. change all floats to doubles? There are only a 32-cells > array and a few local variables, so memory is not a concern.
I found no difference, but using float could help more one day when someone write SIMD code. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
