On Tue, Oct 18, 2016 at 12:46:56PM -0400, Greg Rowe wrote: > >see > >libavfilter/asrc_sine.c > >this code should probably be reused / factored > >(note, any code moving/factoring of existing code should be in a > > seperate patch) > > Since silenceremove works only on AV_SAMPLE_FMT_DBL is it OK to use > floating point for the generated tone or is it recommended to create > the tone and then convert it to double samples or some other > approach?
can you write a fate test for the filter which is portable accross platforms ? every filter should ideally have a fate test. If you can write a working an portable fate test with float sine then i have no objections to it [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
