On 08/23/2016 10:18 PM, Carl Eugen Hoyos wrote:
2016-08-23 11:03 GMT+02:00  <erkki.seppala....@nokia.com>:
+            if (id <= 0 &&
+                st->codecpar->codec_type == AVMEDIA_TYPE_DATA) {
+                id = ff_codec_get_id(ff_codec_metadata_tags, format);
+                if (id > 0)

+                    st->codecpar->codec_type = AVMEDIA_TYPE_DATA;

Is it just me or is this a no-op?

You would be correct. Not only it is never executed, but even if it were, it would do nothing :). (I imagine I copy-paste-search-and-replaced from the one above it and the editing missed this.)

Thanks for review!

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to