On Fri, Mar 25, 2016 at 12:35 AM, Clément Bœsch <u...@pkh.me> wrote: > On Thu, Mar 24, 2016 at 05:50:48PM -0700, Ganesh Ajjanagadde wrote: >> Ganesh Ajjanagadde (4): >> configure: add fftw3 detection >> lavc/fftw: add initial fftw wrapper >> lavc/fft-test: add FFTW3 tests >> lavc/fft-test: update benchmark code >> > > Why? > > Using an external library for such an essential component sounds like > madness to me.
I don't really understand. It is an opt-in dependency, and does not have to be used. Seems like I don't really understand the FFmpeg philosophy; there are a ton of optional libs in configure. FFT is not used in all codecs, so I view it on the same lines as having things like libopus based decoding instead of native FFmpeg decoding, the multiple AAC encoders/decoders, the duplicate prores stuff, libnut on top of the native demuxer, etc, etc. > > If you just want to do benchmarks, add a tool without a dependency in the > configure, because otherwise it will end up being used in the codebase. The intent was to see if it could be integrated into the codebase. Seems like people here have knee jerk reactions to external libs for whatever reason. I would be curious to hear a bit more so that I understand this philo and avoid these things. I recall some here interested in comparing FFTW with our implementation. These patches have enabled reproduction of benchmarks. > > Regards, > > -- > Clément B. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
