On Fri, Mar 25, 2016 at 10:05:09AM +0100, Paul B Mahol wrote:
> On 3/25/16, Ganesh Ajjanagadde <gajja...@gmail.com> wrote:
> > { require libfdk_aac fdk-aac/aacenc_lib.h
> > aacEncOpen -lfdk-aac &&
> > warn "using libfdk without pkg-config"; }
> > }
> > +enabled libfftw3 && require2 libfftw3f "fftw3.h" fftwf_execute
> > -lfftw3f -lm
> > flite_libs="-lflite_cmu_time_awb -lflite_cmu_us_awb -lflite_cmu_us_kal
> > -lflite_cmu_us_kal16 -lflite_cmu_us_rms -lflite_cmu_us_slt -lflite_usenglish
> > -lflite_cmulex -lflite"
> > enabled libflite && require2 libflite "flite/flite.h" flite_init
> > $flite_libs
> > enabled fontconfig && enable libfontconfig
> > --
> > 2.7.4
>
> Big NO from me. Please refrain from doing such silly things.
> Either improve our implementation or do nothing.
I don't disagree with the basic objections, but
I'd appreciate more diplomacy and kindness (and
space for people to explain there motivations)
in the responses.
I am in the habit of liking to call things silly
myself, but honestly almost all patches here
exist for a good reason, even if including
them is not a good idea, and I don't want to
discourage people from sending in interesting
but "silly" things just because they might be derided.
Sorry for the long off-topic.
Thanks,
Reimar
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
