Hi, 2016-03-11 8:57 GMT+01:00 Christophe Gisquet <christophe.gisq...@gmail.com>: >> It should either be reverted or made dependent on >> --enable/disable-debug (I would favor the first, honestly, since its a >> rather ugly hack in itself). > > At the very least, that dependence is needed, yes.
And here's something for the smallest reasonable change. I don't have a strong opinion on actually reverting it, but would lean for it. -- Christophe
From 429a47f83d2d262a3392af34b13dbf14c735c8b9 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet <christophe.gisq...@gmail.com> Date: Sat, 19 Mar 2016 14:45:23 +0100 Subject: [PATCH] mingw64: configure: disable pie with debug enabled This breaks use of gdb. --- configure | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e5de306..e5befa0 100755 --- a/configure +++ b/configure @@ -4604,10 +4604,14 @@ case $target_os in # for dynamicbase (ASLR). Using -pie does retain the reloc section # however ld then forgets what the entry point should be (oops) so we # have to manually (re)set it. + # However, adding -pie breaks debugging through gdb at least under + # mingw, so let's not do this when debugging has been enabled. if enabled x86_32; then add_ldexeflags -Wl,--pic-executable,-e,_mainCRTStartup elif enabled x86_64; then - add_ldexeflags -Wl,--pic-executable,-e,mainCRTStartup + if disabled debug; then + add_ldexeflags -Wl,--pic-executable,-e,mainCRTStartup + fi check_ldflags -Wl,--high-entropy-va # binutils 2.25 # Set image base >4GB for extra entropy with HEASLR add_ldexeflags -Wl,--image-base,0x140000000 -- 2.7.2
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel