Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable parser for mp3s by old HandBrake

[Michael Niedermayer]

On Thu, Dec 10, 2015 at 10:37:42AM +0100, Moritz Barsnick wrote:
> On Wed, Dec 09, 2015 at 22:24:08 +0100, Michael Niedermayer wrote:
> > +            if (sscanf(str, "HandBrake %d.%d.%d", &major, &minor, &micro) 
> > == 3) {
> > +                c->handbrake_version = 1000000*major + 1000*minor + micro;
> [...]
> > +        if (mov->handbrake_version &&
> > +            mov->handbrake_version <= 1000000*0 + 1000*10 + 0 &&
> 
> Really hard to read for all the '1's and '0'. You're checking for "<=
> 0.10.0"? Perhaps better to clearly document that.

comment added


> 
> So starting with 0.10.1, behavior is different?

we have a file from 0.10.0 which is affected, i do not know if
later versions are affected, if somone knows or someone submits
files from later versions which are affected then this can be
updated

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel