Re: [FFmpeg-devel] [PATCH] avformat/mov: Enable parser for mp3s by old HandBrake

[Moritz Barsnick]

On Wed, Dec 09, 2015 at 22:24:08 +0100, Michael Niedermayer wrote:
> +            if (sscanf(str, "HandBrake %d.%d.%d", &major, &minor, &micro) == 
> 3) {
> +                c->handbrake_version = 1000000*major + 1000*minor + micro;
[...]
> +        if (mov->handbrake_version &&
> +            mov->handbrake_version <= 1000000*0 + 1000*10 + 0 &&

Really hard to read for all the '1's and '0'. You're checking for "<=
0.10.0"? Perhaps better to clearly document that.

So starting with 0.10.1, behavior is different?

Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel