Sean McGovern: > Hi, > > > On Fri, Apr 11, 2025, 09:52 Sean McGovern <gsean...@gmail.com> wrote: > >> It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. >> --- >> libpostproc/postprocess.h | 2 ++ >> libpostproc/version.h | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h >> index 5decb7e8a9..7010c2b51b 100644 >> --- a/libpostproc/postprocess.h >> +++ b/libpostproc/postprocess.h >> @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext); >> >> #define PP_CPU_CAPS_MMX 0x80000000 >> #define PP_CPU_CAPS_MMX2 0x20000000 >> +#if PP_AMD_3DNOW >> #define PP_CPU_CAPS_3DNOW 0x40000000 >> +#endif >> #define PP_CPU_CAPS_ALTIVEC 0x10000000 >> #define PP_CPU_CAPS_AUTO 0x00080000 >> >> diff --git a/libpostproc/version.h b/libpostproc/version.h >> index bcbdd210c4..5a272630bf 100644 >> --- a/libpostproc/version.h >> +++ b/libpostproc/version.h >> @@ -43,4 +43,6 @@ >> >> #define LIBPOSTPROC_IDENT "postproc" >> AV_STRINGIFY(LIBPOSTPROC_VERSION) >> >> +#define PP_AMD_3DNOW (LIBPOSTPROC_VERSION_MAJOR < 60)
defines like PP_AMD_3DNOW are not part of the public API and therefore use an FF_ prefix (actually FF_API_ prefix). >> + >> #endif /* POSTPROC_VERSION_H */ >> -- >> 2.39.5 >> > > Did I do this correctly this time? You forgot the APIchanges entry as well as the minor version bump. > > Also it seems a bit much to wait a year or more for this to be actually > removed. Can it instead be keyed to the next minor bump, or is this against > some guarantee we give our downstreams? > Actually, you should bump minor with the deprecation. And yes, this is against the API guarantee for our downstreams. See lavu/avutil.h. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
