On Wed, Nov 13, 2024 at 03:26:40PM +0100, Tomas Härdin wrote: > ons 2024-11-13 klockan 14:40 +0100 skrev Michael Niedermayer: > > Hi > > > > On Tue, Oct 29, 2024 at 03:44:30PM +0100, Tomas Härdin wrote: > > > Needs a sample. An option or setting for probe size might be a good > > > idea > > > > > > Spotify comments > > > ---------------- > > > In mp3 files, id3v2 tag with huge cover art causes the probe code > > > to > > > not identify valid mp3 files as mp3. Increase default buffer so > > > that > > > probe can see mp3 frames. > > > > Does this work if its limited to cases where huge ID3 is detected ? > > or we could seek forward over the ID3 detect format and then go > > back and do the normal open code > > Can't we have it just rely on there being an ID3 header? Are there > counterexamples? >
> The probe logic (av_probe_input_format3()) has special logic for ID3 > headers, skipping past them to allow the normal MP3 probing to inspect > the essence data following the header. This only works if it's given > enough probe data > > Seeking can be expensive, especially when the data is served over HTTP anything that works is fine. The better it works, the more often, the better If seeking makes sense probably depends on the relative cost of seeking vs. bandwidth We already have places where similar decissions needs to be made, like when deciding if we seek forward or just keep reading. One problem with never seeking is that it requires a limit in how much can be read. Above that a ID3 will fail somehow instead of being slow I faintly remember that there was prior discussion about seeking and id3 probing long ago. Either way i have no real oppinion on this, above is just some dump of related thoughts. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
