Any issues remaining with this patch? Thanks in advance for applying. - dale
On Sun, Sep 22, 2024 at 4:30 PM Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Aug 14, 2024 at 08:29:37AM +0200, Christophe Gisquet wrote: > > Hi, > > > > Le mar. 13 août 2024 à 23:39, Dale Curtis <dalecur...@chromium.org> a > écrit : > > > > > > On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes <h.lepp...@gmail.com> > wrote: > > > > > > > Disabling random codec features seems like an anti-feature to me, in > > > > the future it'll make every feature be questioned and compile-time > > > > conditional, and make everything terrible. > > > > If the context size is the major concern, maybe large structures > > > > should be allocated when in use, rather than always? > > > > > > > > > > I agree with that, so here's a version which allocates dynamically > instead. > > > It passes FATE, but I didn't try with valgrind/msan in case I missed a > > > cleanup path. > > didnt review, but i think the patch is a good idea > > > > > > (not an author) > > Probably there is remaining work pending on external dependencies, but > > H274FilmGrainDatabase sounds a bit adhoc. The 8KB of slice_tmp for one > > could just be a local variable in init_slice(). > > > The 676KB (!) of the > > noise database are a bit more puzzling and could be the one that needs > > 676KB is quite large for generating noise with a specific spectra. But > maybe iam missing something > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Let us carefully observe those good qualities wherein our enemies excel us > and endeavor to excel them, by avoiding what is faulty, and imitating what > is excellent in them. -- Plutarch > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
