On Wed, Feb 21, 2024 at 02:39:42AM +0100, Jean-Baptiste Kempf wrote: > Yo, > > On Tue, 20 Feb 2024, at 15:31, Michael Niedermayer wrote: > > I did hear (at fosdem?) > > about the idea to switch from rsync to git for managing the fate samples > > i thought the idea sounds interresting but isnt rsync more efficient ? > > Yes, that's my idea. > > The git part is not for others clients to sync, but just to manage the > samples. > > It allows to have versioning of the samples, with the extra ability to have > branches and tags matching the ffmpeg branches.
versioning is fine branches, we did not need, and adding branches sounds like a solution searching for a problem > It avoids the weird dance "waiting for FATE admin to upload thing", because > their would be multiple approvers/committers to that repo. we have 15 people in the samples group that have the power to upload samples, the bottleneck is that only 2 of them actual do upload and noone else is volunteering > It simplifies the workflow on the admin side, since with a git hook, the > server does "git update" in the directory that will be rsync'd by the > mirrors. And it does not change their workflow, still using rsync. It still requires people to push the new sample to git and that git is a different architecture than how the samples normally where downloaded if you keep rsync I mean everyone has a rsync based checkout like now for "make fate" updating with "make fate-rsync" they add a sample to this and then they have no git to push that to cuz, no .git directory is there. This can be handled in a few ways but it mainly seems messy what i suggest is that someone adds a make fate-rsync-upload that runs the rsync command that way the other people who actually have fate samlpe upload rights actually do the upload after testing a patch instead of waiting for 2 people to do it. Such "fate-rsync-upload" is easy and needs no change to architecture it also doesnt make any future change to architecture any more difficult so i suggets that to be done together with people volunteering to do fate sample uploads themselfs if they freuqently review/approve patches that need such uploads If people prefer switching to git then we need an volunteer to write and test the related hook(s). I can create a git repo for it Iam mainly hesitant now because it seems an additional layer not replacing a layer thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart than the original author, trying to rewrite it will not make it better.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
