Hi guys! I'm currently working under extension of QSV support in ffmpeg. Could please anybody say, are there any serious reasons to use external SPS parser into the qsv_process_data() of libavcodec/qsvdec_h264.c instead nice MFXVideoDECODE_DecodeHeader() function? Looks like it is just rudiment of initial implementation but may be it is really important by some reason? Thank!
This is a forwarded message From: Hendrik Leppkes <h.lepp...@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> CC: Date: Thursday, July 16, 2015, 11:57:25 PM Subject: [FFmpeg-devel] libavcodec/qsvdec_h264.c: SPS parsing now performs by MFXVideoDECODE_DecodeHeader() into libavcodec/qsvdec.c ===8<==============Original message text=============== On Thu, Jul 16, 2015 at 10:02 PM, Ivan Uskov <ivan.us...@nablet.com> wrote: > Hello All, > > Current implementation of libavcodec/qsvdec_h264.c does use external > SPS parser. It does not optimal since MFX library has own unified way > to parse headers of all supported formats. This performs by one > MFXVideoDECODE_DecodeHeader() call. > The suggested patch does replace stream specific code to one universal > function call located into the libavcodec/qsvdec.c. This opens an easy > way to implement qsv-accelerated mpeg2, hevc and vc1 decoders. > Please review. There was a specific reason this was done this way. You should definitely inquire with the original author of this code for the reason of not using the header parser, IIRC it was broken in some cases. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ===8<===========End of original message text=========== -- Best regards, Ivan mailto:ivan.us...@nablet.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
