Hi Michael, Andreas, On Thu, 21 Sept 2023 at 22:50, Andreas Rheinhardt <andreas.rheinha...@outlook.com> wrote: > > Michael Niedermayer: > > On Thu, Sep 21, 2023 at 02:17:00PM +0200, Clément Péron wrote: > >> Output the producer reference time to a dirty raw output. > >> > >> Signed-off-by: Clément Péron <peron.c...@gmail.com> > >> --- > >> libavformat/rawenc.c | 122 +++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 122 insertions(+) > > > > this breaks fate-filter-volume and others > > (Segmentation fault) > > > > I can rerun it with debug symbols and provide peoper gdb output > > but i suspect given this has "HACK" in the title you are aware of this
The "HACK" tag meaning was not supposed to be: "it's ok if it segfaults", but more to trigger a discussion is it possible to properly support an output timestamp in the raw video demux, and if yes how to do it :) I consider this patch dirty and not upstreamable like this. I thought about it during the night and would it be ok to add a "raw_fmt" option. -raw_fmt="prft:packet" or -raw_fmt="packet:prft" or -raw_fmt="prft" to only output the prft packet If you have another idea I would be glad to hear it, thanks > > > > The reason is that this patch presumes that every user of > ff_raw_write_packet() uses the newly added RawVideoContext as context, > but that is just not true. Thanks for the explanation, I will fix it in v2, Clement > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
