> -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Michael > Niedermayer > Sent: Wednesday, December 22, 2021 8:54 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Politics > > On Wed, Dec 22, 2021 at 01:29:04PM +0000, Soft Works wrote: > > > > > > > -----Original Message----- > > > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of Michael > > > Niedermayer > > > Sent: Monday, December 20, 2021 4:24 PM > > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] Politics > > > > > > I am not sure the direction from which you approuch this is going to > > > increase the chances this patch has. > > > > > > All stream types in libavformat/codec are timebase based, that was > > > done because its exact (for some definition of exact at least) > > > > > > I think you should argue why this is the best way forward not why its > > > not too bad > > > > > > also in a few places where a fixed timebase is used ffmpeg uses > > > AV_TIME_BASE_Q which is micro not milli seconds. That suddenly > > > allows exactly addressing individual frames and audio samples. > > > And it should be easy to change to from ms, its just a *1000 > > > it would weaken the precission argument > > > > For the final chapter of this story, let us return to the original > > subject which I would summarize like: > > > > [...] > > > I think I know better and therefore insist > > on having a higher precision and/or flexible timebase for subtitle > > timings, otherwise I won't accept the patchset" > > I didnt say any of this
And you weren't meant at all. (you're actually one of the persons I'm respecting the most) Sorry for the misunderstanding. I should have replied to one of the earlier messages. I thought the fictional quote would make it clear who is meant. > > Let's look at the concern first: The concern is about that with > > a subtitle precision of milliseconds (let's say milli, even > > though we actually have microseconds), it would not be possible > > Not sure i understand you but the code you add to AVFrame says "ms" and > thats milli not micro, > the prefix for micro is the SI system is μ or u if you want ASCII subtitle_pts is AV_TIMEBASE_Q. I had recently suggested to change the other fields (subtitle_start_time and subtitle_end_time to AV_TIMEBASE_Q as well, to have all subtitle timing fields at the same base. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
