I also am not accepting a hardcoded timebase of microseconds. Rounding really matters for subtitles, since presenting them a frame early or late is unacceptable
That's simply not true. I don't accept or deny a hardcoded microseconds timebase; that's beyond my knowledge to judge. What I say is not true is the other sentence: "presenting them a frame early or late is unnaceptable". That's a gross exaggeration, and should not be a blocker. In my country everyone uses subtitles since decades ago, and people cares about timing only when there's seconds of desync. Yeah, seconds in plural: a single second most likely would be accepted. We're talking about dozens of frames here. Of course, I wouldn't say "innacurate is right". But I wouln't also block other people's work using unreal standards. Now, DRIFTING would be a different beast, and microseconds leaks should be a serious issue for 24/7 streams. I don't see people debating such problem, and "a sigle frame off" is a wrong angle for talking milliseconds precision and rounding. Also, I did some tests with softworkz code, and timings seems working fine with production inputs. I saw several people here talking about complex graphs with different timebases, and changes between subtitle formats. I believe the debate would be much less abstract if somebody could kindly put some example here we could all test for ourselves. I understand nobody could have a full idea of all possible scenarios: that would be unfair to ask for. But I believe people with observations about possible breaking use cases would have such use cases more likely available in mind and could share them with us. I DID actually find problems with timings in softworkz code. But those problems were anything like the things debated here. You see, I've tried to use setpts and asetpts in my graphs, yet there's no ssetpts. Other filters had the same problem. Also, there are live-streaming muxers and codecs that does not support subtitles. See this, for example: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hls.c#L506 Or this: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/dashenc.c#L1066 But I believe those issues can be handled isolated once there's subtitle filtering implemented, so I don't consider them part of this debate per se. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
