On Fri, Oct 22, 2021 at 1:13 AM Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Fri, Oct 22, 2021 at 12:32:18AM +0300, Jan Ekström wrote: > > On Fri, Oct 22, 2021 at 12:21 AM Jan Ekström <jee...@gmail.com> wrote: > > > > > > On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer > > > <mich...@niedermayer.cc> wrote: > > > > > > > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > > > > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > > > > > <mich...@niedermayer.cc> wrote: > > > > > > > > > > > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > > > > > > > On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström <jee...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > Originally added as a private entry in commit > > > > > > > > 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with > > > > > > > > the comment noting its private state was missed during merging > > > > > > > > of > > > > > > > > the field from Libav (most likely due to an already existing > > > > > > > > field > > > > > > > > in between). > > > > > > > > --- > > > > > > > > > > > > Its a public struct in a public header so deprecate > > > > > > > > > > > > thx > > > > > > > > > > > > > > > > OK, just confirming but so you don't consider this to be of the same > > > > > type as these > > > > > http://git.videolan.org/?p=ffmpeg.git;a=blobdiff;f=libavformat/avio.h;h=a7b56ab6674f0a25be3b480df314e2d1292f397b;hp=0b35409787c925d681a121aa8d8715c3921fddf2;hb=45bfe8b838275235412777dd430206d9a24eb3ee;hpb=530ac6aa305aeda631c77f8a17e96c14c7ab1a1c > > > > > ? > > > > > > > > i assume this was during ABI bumping, > > > > when the major version numbers change then ABI/API breaking changes can > > > > be > > > > done. > > > > > > > > > > IIRC ABI breakage after bumping was supposed to be a ~month but then > > > IIRC people posted such things much later. Was there a message or note > > > when this period ended? > > Maybe someone assumed that everyone agreed what "a ~month" is ? > > > > > > > > > This commit > > (http://git.videolan.org/?p=ffmpeg.git;a=commit;h=45bfe8b838275235412777dd430206d9a24eb3ee) > > was applied in late August (as the entries were private - kind of like > > this one remaining entry), and I can find Anton noting in May that the > > project is in ABI instability period. So do excuse me for not knowing > > which mode we are in right now if it went on for at least four months > > :D > > I think you should really implement a full statistics API instead of > this as you clearly have alot of time.
I do not have a lot of time, I just saw this as a finalization of the clean-up of private fields that Andreas started and I wanted to ask about which people would prefer, since we have not yet had a release branching with the API major version that this clean-up is included in. If you disagree with Andreas's actions from late August, then I would have preferred you to note that. I would have been OK with something a la "It was not clearly marked in our (FFmpeg's) merge so we consider it public and not private.", instead I got what (at least to me) felt like re-education on what API/ABI breaks are, plus what seemed to be not reading all those references I provided to why I thought this was a private field and why this in my opinion was just a continuation of the previous commit done by Andreas. I am sorry for the knee-jerk reflex-like response, it is not productive. I think I just felt like getting ignored and getting a standard "he doesn't understand the basics of this basic thing" response, even though I attempted to provide all the information regarding *why* I was asking. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
