On Sun, Dec 6, 2020 at 5:44 PM James Almer <jamr...@gmail.com> wrote: > > Create a local one instead from a byte buffer input argument. > > Signed-off-by: James Almer <jamr...@gmail.com>
The actual change mentioned in the commit message is LGTM, and the updated sanity checks seem good (since now the alternatives at that point are either 3+3 (2094-40) or 3+4 (closed captions)), but they are pretty separate from the actual change of this commit. So in that sense it might make sense to just separate them into their own fixup commit when pushing. Or at least mention the sanity check fixups in the commit message instead of them being a silent good change. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
