On Fri, Oct 30, 2020 at 03:15:08PM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-10-30): > > Sorry, I ignore it for I haven't realized it's a question in fact. > > Please do not ignore things people write to you. If they (I) took time > writing it, there must be a reason. > > > Without the first scale, it'll report error, but without the final scale, > > no error report but it's not work as expected, do you think it's necessary > > to report error in the case? > > As I said, the final scale is necessary for big-endian architectures. > Did you test on a big-endian architecture? If not, then you do not see > any consequence for this filter, but it needs to be there.
thanks, I see the point now, I haven't got error just for my system is little-endian. > > The first scale can be avoided if you use testsrc2, as I said. If you > use vsynth, it is necessary. Testing that requires less extra code is > better. OK, I'll update the patch to use testsrc2 instead of vsync for testing. > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
