On Fri, Aug 14, 2020 at 08:20:28PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Aug 13, 2020 at 12:41:26PM +0100, Jack Haughton wrote: > >> Commit a500b975 removed NULL input handling from this function, > >> moving the check higher up the call tree in one branch. However, > >> there is another call to set_string_video_rate() which may pass > >> NULL, and future users of the function may not be clear that > >> a NULL check is required. This patch restores the NULL check to > >> avoid these problems. > >> --- > >> libavutil/opt.c | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > > > > will apply > > > > thx > > > But is a NULL default value actually invalid/nonsense? I think not. See > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-August/267444.html
replied there thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
