Michael Niedermayer: > On Thu, Aug 13, 2020 at 12:41:26PM +0100, Jack Haughton wrote: >> Commit a500b975 removed NULL input handling from this function, >> moving the check higher up the call tree in one branch. However, >> there is another call to set_string_video_rate() which may pass >> NULL, and future users of the function may not be clear that >> a NULL check is required. This patch restores the NULL check to >> avoid these problems. >> --- >> libavutil/opt.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > will apply > > thx > But is a NULL default value actually invalid/nonsense? I think not. See https://ffmpeg.org/pipermail/ffmpeg-devel/2020-August/267444.html
I can send a patch implementing this if others agree with my reasoning. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
