On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: > On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: > > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); > > > ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)); > > > ff_set_common_samplerates(ctx, ff_all_samplerates()); > > > > > What do you do about the 2nd argument being NULL by allocation error here? > > Should the ctx passed there too?
there are many possibilities like returning a specific pointer to a struct indicating errors but passing ret may be more intuitive [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
