On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: > Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : > > ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); > > ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)); > > ff_set_common_samplerates(ctx, ff_all_samplerates()); > >
What do you do about the 2nd argument being NULL by allocation error here?
Should the ctx passed there too?
> > return ctx->ff_errno;
>
> I wanted to suggest something along this line too. Since the functions are
> private and can be changed, I suspect the error code would be better carried
> around in a value passed as argument.
>
That would also make the calls to query_formats() between filters more
easily thread safe.
So...
int ret = 0;
ff_set_common_channel_layouts(ctx, ff_all_channel_layouts(&ret), &ret);
ff_set_common_formats(ctx, ff_make_format_list(sample_fmts, &ret), &ret);
ff_set_common_samplerates(ctx, ff_all_samplerates(&ret), &ret);
return ret;
?
--
Clément B.
pgpiAf43l8J_r.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
