On 12.11.2014 09:03, Nicolas George wrote:
Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit :
TODO: bump minor version, update doc/APIchanges

New function allows to check if option is set to its default

I am a bit uncomfortable with that API: this function does not test whether
an option is set to its default but if an option is set to the same value as
its default. That leaves a lot of room for bad use. If the user explicitly
sets an option to a value, it should not be considered default, even if the
value is the same as the default.

This is true, but I don't see any solution without extra flag for each option "instance". I can add a comment about it in docs. BTW, You commented commit message, but in docs it has added "value" word at the end, which makes is more true.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to