On Fri, Oct 24, 2014 at 10:08:21PM +0200, Lukasz Marek wrote: > On 22.10.2014 02:02, Michael Niedermayer wrote: > > > >it seems the only use of this function is under #if CONFIG_AVDEVICE > >so the fallback shouldnt be needed > >same for the other function > > > >also mising documentation and example in docs > > Updated patch is attached. >
[...]
> index 7b6afba..18027d2 100644
> --- a/doc/fftools-common-opts.texi
> +++ b/doc/fftools-common-opts.texi
> @@ -138,6 +138,22 @@ Show channel names and standard channel layouts.
> @item -colors
> Show recognized color names.
>
> +@item -sources
> @var{device}[,@var{opt1}=@var{val1}[,@var{opt2}=@var{val2}]...]
> +Show autodetected sources of the intput device.
> +Some devices may provide system-dependent source names that cannot be
> autodetected.
> +The returned list cannot be assumed to be always completed.
complete
> +@example
> +ffmpeg -sources pulse,server=192.168.0.4
> +@end example
> +
> +@item -sinks @var{device}[,@var{opt1}=@var{val1}[,@var{opt2}=@var{val2}]...]
> +Show autodetected sinks of the output device.
> +Some devices may provide system-dependent sink names that cannot be
> autodetected.
> +The returned list cannot be assumed to be always completed.
complete
i wonder if some of the code can be factorized/simplifed but either
way it LGTM
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
