On Thu, Jun 19, 2014 at 06:59:48PM +0200, Clément Bœsch wrote: > On Thu, Jun 19, 2014 at 04:23:55PM +0000, Carl Eugen Hoyos wrote: > > Clément Bœsch <u <at> pkh.me> writes: > > > > > > If your patch is really what everybody wants, please > > > > add a fallback that allows to try the current > > > > way of building if pkg-config returns that the > > > > library is missing. > > > > > > How am I supposed to do that? > > > > > > add a --enable-manual-detection-libx264? > > > > Sorry, I meant the variant that you proposed last week: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2014-June/158707.html > > > > enabled libx264 && require_pkg_config x264 || > > require libx264 x264.h ... > > > > In that case, I probably need to add a libx264 exception in > require_pkg_config, because after patch 3 it will die if pkg-config is not > found. That's going to be pretty ugly. > > Is everyone fine with that? >
Carl, do you want the fallback to work just when pkg-config is not available or do you actually want a real fallback when it is present but didn't succeed? (the second solution is way uglier to solve) -- Clément B.
pgpA1X4yR8Vt4.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
