On 8/7/14, Daniel Oberhoff <danieloberh...@gmail.com> wrote:
>
> Am 06.08.2014 um 12:12 schrieb Clement Boesch <u...@pkh.me>:
>
>> On Sun, Aug 03, 2014 at 06:43:18PM +0200, Daniel Oberhoff wrote:
>> [...]
>>>>> +static av_cold int init(AVFilterContext *ctx)
>>>>> +{
>>>>> + return 0;
>>>>> +}
>>>>>
>>>>
>>>> please remove this one, there is no point in having code that does
>>>> nothing.
>>>>
>>>>> +
>>>>> +static av_cold void uninit(AVFilterContext *ctx)
>>>>> +{
>>>>> +}
>>>>> +
>>>>>
>>>>
>>>> ditto
>>>>
>>>
>>> Done thanks!
>>>
>>
>> Did you forget to attach the latest version of the patch or I missed it
>> somewhere in the thread?
>
> Sorry, think that day I wanted to add something else before resubmit, and
> then lost the time.
>
> Here also with changes suggested by timothy. Note that the parametrization
> is now traditional
> (i.e. k1 and k2 are zero-based, as for example in the opencv documentation
> about calibration).
>
> From b798b95eb2f9ec4043b2407970d351cc31dd9e6a Mon Sep 17 00:00:00 2001
> From: Daniel Oberhoff <dan...@danieloberhoff.de>
> Date: Mon, 28 Jul 2014 23:58:12 +0200
> Subject: [PATCH] avfilter: ported lenscorrection filter from frei0r
>
> ---
> Changelog | 2 +-
> MAINTAINERS | 1 +
> doc/filters.texi | 46 +++++++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/version.h | 4 +-
> libavfilter/vf_lenscorrection.c | 199
> +++++++++++++++++++++++++++
> tests/fate/filter-video.mak | 3 +
> tests/ref/fate/filter-pixfmts-lenscorrection | 8 ++
> 9 files changed, 262 insertions(+), 3 deletions(-)
> create mode 100644 libavfilter/vf_lenscorrection.c
> create mode 100644 tests/ref/fate/filter-pixfmts-lenscorrection
>
probably ok
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
