On Fri, Aug 01, 2014 at 12:56:42PM +0200, Daniel Oberhoff wrote: > > Am 01.08.2014 um 12:22 schrieb Clément Bœsch <u...@pkh.me>: > > > On Fri, Aug 01, 2014 at 12:13:22PM +0200, Daniel Oberhoff wrote: > >> > >> Am 29.07.2014 um 09:54 schrieb Carl Eugen Hoyos <ceho...@ag.or.at>: > >> > >>> Daniel Oberhoff <danieloberhoff <at> gmail.com> writes: > >>> > >>>> OBJS-$(CONFIG_ZOOMPAN_FILTER) += vf_zoompan.o > >>>> +OBJS-$(CONFIG_RECTIFICATION_FILTER) += vf_rectification.o > >>> > >>>> REGISTER_FILTER(ZOOMPAN, zoompan, vf); > >>>> + REGISTER_FILTER(RECTIFICATION, rectification, vf); > >>> > >>> Keep the alphabetic ordering please. > >>> > >> > >> Ok > >> > >>>> + AV_PIX_FMT_YUV410P, > >>>> + AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUVJ444P, > >>>> + AV_PIX_FMT_YUV420P, AV_PIX_FMT_YUVJ420P, > >>>> + AV_PIX_FMT_YUVA444P, AV_PIX_FMT_YUVA420P, > >>>> + AV_PIX_FMT_NONE > >>> > >>> I have no idea what this filter does and since the > >>> most important format (yuv420p) is supported, this > >>> doesn't really matter but yuv410p and yuva444p are > >>> quite exotic formats, I would at least have > >>> expected yuv422p, yuva420p and yuv444p in the list. > >>> > >>> Did you test all above formats (at least the left row)? > >> > >> Added the one from your list that was missing. Can you suggest an easy way > >> of testing all these formats? > >> > > > > > > add a format filter before yours in the filtergraph (-vf > > format=yuv410p,rectification …) > > Ok, borders can be a bitt different, but otherwise all work now, except > vuy444p, which ffmpeg reports as invalid. btw, how can I get the components > of a given color in the colorspace? > > > If you want to add a FATE test (which would be really awesome), you can > > grep for "video_filter" in tests/fate/filter-video.mak (to test all pixel > > formats the filter supports), or just make a standard test with framecrc. > > > > [...] > > I did that by adding this: > > FATE_FILTER_PIXFMTS-$(CONFIG_RECTIFICATION_FILTER) += > fate-filter-pixfmts-rectification > fate-filter-pixfmts-rectification: CMD = pixfmts "0.6:0.4:0.65:0.4" > > then I ran > > make fate-filter-pixfmts-rectification GEN=1 > > which made a file > > test/data/fate/filter-pixfmts-rectification.rep >
This is the result of a normal run to be compared by with the reference which should have also been generated with the help of GEN=1 for your first run. The file(s) generated by GEN=1 need to be tracked. > do I check this in or not? > Of course you are supposed to check if the results make sense. Use make fate-filter-pixfmts-rectifications V=1 to see what's going on. > running > > make fate-filter-pixfmts-rectification GEN=1 > > runs fine… > Of course, it doesn't do the comparison, it generates the reference. > Best > > Daniel -- Clément B.
pgpteYNTmAvUd.pgp
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
