On Wed, Jul 16, 2014 at 08:18:58AM +0200, Reimar Döffinger wrote: > > > On 15.07.2014, at 16:31, Michael Niedermayer <michae...@gmx.at> wrote: > > > Found-by: kriegero1 > > Signed-off-by: Michael Niedermayer <michae...@gmx.at> > > Nit: iNdependent in commit message.
fixed > > > + /* JFIF header */ > > + put_marker(p, APP0); > > + put_bits(p, 16, 16); > > + avpriv_put_string(p, "JFIF", 1); /* this puts the trailing zero-byte > > too */ > > + put_bits(p, 16, 0x0102); /* v 1.02 */ > > + put_bits(p, 8, 0); /* units type: 0 - aspect ratio */ > > Would an empty JFIF header possibly help as well? (I think it's a collection > of tags or am I wrong and it requires an aspect entry?) > I don't like specifying a 1:1 aspect explicitly when we actually don't know > it. from what i see in the spec this isnt optional, but i read just a small part of the spec also the spec isnt big ... > Also, might the diff be more readable without reindenting? probably, ill do it in case this is commited, one concern is still if we need to special case this for mjpeg so it gets no jfif [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
