Arik Hadas has posted comments on this change. Change subject: core: fix compensation for import and clone vm ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41213/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 207: protected final void postConstruct() { Line 208: // do not initialize for compensation Line 209: if (getParameters() != null) { Line 210: init(); Line 211: } > IMO this condition is not part of CommandBase, it should be part of init() but that's true for all commands that use post-construct initialization - nothing should be done when instantiating the command for compensation (a different question is whether we have to instantiate the command for compensation, probably not but that's what we currently have). I prefer the framework to enforce it, and not to have this duplicated code everywhere.. Line 212: } Line 213: Line 214: /** Line 215: * Implement this method whenever you need extra initialization of the command after the -- To view, visit https://gerrit.ovirt.org/41213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
