Arik Hadas has uploaded a new change for review. Change subject: core: fix compensation for import and clone vm ......................................................................
core: fix compensation for import and clone vm If the initialization that is done in post-construct accessed the command's parameters in a non-transactive command that uses compensation, the compensation didn't work. The problem is that when instantiate the command for compensation, the parameters are not passed, so the initialization in the post-construct failed. The solution is to do the initialization in post-construct only when the parameters are set. Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/41213/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index bafe1c8..d3d8e70 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -205,7 +205,10 @@ */ @PostConstruct protected final void postConstruct() { - init(); + // do not initialize for compensation + if (getParameters() != null) { + init(); + } } /** -- To view, visit https://gerrit.ovirt.org/41213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
